]> err.no Git - linux-2.6/commitdiff
[PACKET]: Don't truncate non-linear skbs with mmaped IO
authorPatrick McHardy <kaber@trash.net>
Mon, 18 Sep 2006 06:59:57 +0000 (23:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 18 Sep 2006 06:59:57 +0000 (23:59 -0700)
Non-linear skbs are truncated to their linear part with mmaped IO.
Fix by using skb_copy_bits instead of memcpy.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/packet/af_packet.c

index f9cef3671593efaf7a513efacc3097fc27743507..4172a5235916e3f71ee6fbed85b4c296ab9de3c4 100644 (file)
@@ -626,8 +626,6 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, struct packe
                if ((int)snaplen < 0)
                        snaplen = 0;
        }
-       if (snaplen > skb->len-skb->data_len)
-               snaplen = skb->len-skb->data_len;
 
        spin_lock(&sk->sk_receive_queue.lock);
        h = (struct tpacket_hdr *)packet_lookup_frame(po, po->head);
@@ -644,7 +642,7 @@ static int tpacket_rcv(struct sk_buff *skb, struct net_device *dev, struct packe
                status &= ~TP_STATUS_LOSING;
        spin_unlock(&sk->sk_receive_queue.lock);
 
-       memcpy((u8*)h + macoff, skb->data, snaplen);
+       skb_copy_bits(skb, 0, (u8*)h + macoff, snaplen);
 
        h->tp_len = skb->len;
        h->tp_snaplen = snaplen;