]> err.no Git - linux-2.6/commitdiff
[IPV6]: ICMP6_MIB_OUTMSGS increment duplicated
authorWang Chen <wangchen@cn.fujitsu.com>
Mon, 21 Jan 2008 11:04:47 +0000 (03:04 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jan 2008 11:05:20 +0000 (03:05 -0800)
icmpv6_send() calls ip6_push_pending_frames() indirectly.
Both ip6_push_pending_frames() and icmpv6_send() increment
counter ICMP6_MIB_OUTMSGS.

This patch remove the increment from icmpv6_send.

Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/icmp.c

index 9bb031fa1c2f538c827402e3ecc8f90774fd6a55..f1240688dc5849ca469566f9830b473ac36a0814 100644 (file)
@@ -458,8 +458,6 @@ void icmpv6_send(struct sk_buff *skb, int type, int code, __u32 info,
        }
        err = icmpv6_push_pending_frames(sk, &fl, &tmp_hdr, len + sizeof(struct icmp6hdr));
 
-       ICMP6_INC_STATS_BH(idev, ICMP6_MIB_OUTMSGS);
-
 out_put:
        if (likely(idev != NULL))
                in6_dev_put(idev);