]> err.no Git - linux-2.6/commitdiff
[PATCH] coverity: fs/ext3/super.c: match_int return check
authorKAMBAROV, ZAUR <kambarov@berkeley.edu>
Wed, 29 Jun 2005 03:45:11 +0000 (20:45 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Wed, 29 Jun 2005 04:20:34 +0000 (21:20 -0700)
The return value of  "match_int" is  checked  27 out of 28 times

In lib/parser.c
142   /**
143    * match_int: - scan a decimal representation of an integer from a substring_t
144    * @s: substring_t to be scanned
145    * @result: resulting integer on success
146    *
147    * Description: Attempts to parse the &substring_t @s as a decimal integer. On
148    * success, sets @result to the integer represented by the string and returns 0.
149    * Returns either -ENOMEM or -EINVAL on failure.
150    */
151   int match_int(substring_t *s, int *result)
152   {
153   return match_number(s, result, 0);
154   }

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/ext3/super.c

index b4b3e8a39131fbb247f2c633c26cfa2ac16ba6b9..a6d1779d7de4a00fcc205142bb54dd2e83efb0a2 100644 (file)
@@ -944,7 +944,8 @@ clear_qf_name:
                                        "for remount\n");
                                return 0;
                        }
-                       match_int(&args[0], &option);
+                       if (match_int(&args[0], &option) != 0)
+                               return 0;
                        *n_blocks_count = option;
                        break;
                case Opt_nobh: