]> err.no Git - linux-2.6/commitdiff
[TG3]: Remove unnecessary tx_lock
authorMichael Chan <mchan@broadcom.com>
Sun, 18 Jun 2006 04:55:55 +0000 (21:55 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Jun 2006 04:55:55 +0000 (21:55 -0700)
Remove tx_lock where it is unnecessary. tg3 runs lockless and so it
requires interrupts to be disabled and sync'ed, netif_queue and NAPI
poll to be stopped before the device can be reconfigured. After
stopping everything, it is no longer necessary to get the tx_lock.

Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/tg3.c

index 3c9b13b3cf9b3c5ce8c0b0a8498fd5751f8e93de..542d4c3a10e5e6d1da5a4b0744d121ba9c15cbbc 100644 (file)
@@ -2984,9 +2984,7 @@ static void tg3_tx_recover(struct tg3 *tp)
               "and include system chipset information.\n", tp->dev->name);
 
        spin_lock(&tp->lock);
-       spin_lock(&tp->tx_lock);
        tp->tg3_flags |= TG3_FLAG_TX_RECOVERY_PENDING;
-       spin_unlock(&tp->tx_lock);
        spin_unlock(&tp->lock);
 }
 
@@ -3429,12 +3427,10 @@ static inline void tg3_full_lock(struct tg3 *tp, int irq_sync)
        if (irq_sync)
                tg3_irq_quiesce(tp);
        spin_lock_bh(&tp->lock);
-       spin_lock(&tp->tx_lock);
 }
 
 static inline void tg3_full_unlock(struct tg3 *tp)
 {
-       spin_unlock(&tp->tx_lock);
        spin_unlock_bh(&tp->lock);
 }