]> err.no Git - linux-2.6/commitdiff
[NET_SCHED]: sch_ingress: remove unnecessary ops
authorPatrick McHardy <kaber@trash.net>
Mon, 21 Jan 2008 08:12:53 +0000 (00:12 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 23:08:20 +0000 (15:08 -0800)
- ->reset is optional
- sch_api provides identical defaults for ->dequeue/->requeue
- ->drop can't happen since ingress never has a parent qdisc

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_ingress.c

index 1bbc648f06ee087d37e50b6f64500e9d088ce6f7..c69e7bc7fb6c4d948ac0cfcdff1f5fd271bec704 100644 (file)
@@ -118,21 +118,6 @@ static int ingress_enqueue(struct sk_buff *skb, struct Qdisc *sch)
        return result;
 }
 
-static struct sk_buff *ingress_dequeue(struct Qdisc *sch)
-{
-       return NULL;
-}
-
-static int ingress_requeue(struct sk_buff *skb, struct Qdisc *sch)
-{
-       return 0;
-}
-
-static unsigned int ingress_drop(struct Qdisc *sch)
-{
-       return 0;
-}
-
 #ifndef CONFIG_NET_CLS_ACT
 #ifdef CONFIG_NETFILTER
 static unsigned int ing_hook(unsigned int hook, struct sk_buff *skb,
@@ -202,11 +187,6 @@ static int ingress_init(struct Qdisc *sch, struct rtattr *opt)
        return 0;
 }
 
-static void ingress_reset(struct Qdisc *sch)
-{
-       return;
-}
-
 /* ------------------------------------------------------------- */
 
 static void ingress_destroy(struct Qdisc *sch)
@@ -248,11 +228,7 @@ static struct Qdisc_ops ingress_qdisc_ops __read_mostly = {
        .id             =       "ingress",
        .priv_size      =       sizeof(struct ingress_qdisc_data),
        .enqueue        =       ingress_enqueue,
-       .dequeue        =       ingress_dequeue,
-       .requeue        =       ingress_requeue,
-       .drop           =       ingress_drop,
        .init           =       ingress_init,
-       .reset          =       ingress_reset,
        .destroy        =       ingress_destroy,
        .dump           =       ingress_dump,
        .owner          =       THIS_MODULE,