]> err.no Git - linux-2.6/commitdiff
libata: remove irq_on from ata_bus_reset() and ata_std_postreset()
authorAlbert Lee <albertcc@tw.ibm.com>
Sat, 7 Jul 2007 07:00:37 +0000 (15:00 +0800)
committerJeff Garzik <jeff@garzik.org>
Thu, 12 Jul 2007 20:12:15 +0000 (16:12 -0400)
  It seems irq_on() in ata_bus_reset() and ata_std_postreset()
are leftover of the EDD reset. Remove them.

Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c
drivers/ata/pata_scc.c

index e127b73e32a4230ea87d318d03fba6c79c35e0d2..88e2dd0983b536cc31c3dfd6d44ffafa1f2854fc 100644 (file)
@@ -3164,9 +3164,6 @@ void ata_bus_reset(struct ata_port *ap)
        if ((slave_possible) && (err != 0x81))
                ap->device[1].class = ata_dev_try_classify(ap, 1, &err);
 
-       /* re-enable interrupts */
-       ap->ops->irq_on(ap);
-
        /* is double-select really necessary? */
        if (ap->device[1].class != ATA_DEV_NONE)
                ap->ops->dev_select(ap, 1);
@@ -3551,10 +3548,6 @@ void ata_std_postreset(struct ata_port *ap, unsigned int *classes)
        if (sata_scr_read(ap, SCR_ERROR, &serror) == 0)
                sata_scr_write(ap, SCR_ERROR, serror);
 
-       /* re-enable interrupts */
-       if (!ap->ops->error_handler)
-               ap->ops->irq_on(ap);
-
        /* is double-select really necessary? */
        if (classes[0] != ATA_DEV_NONE)
                ap->ops->dev_select(ap, 1);
index 274fabfc90e107368889bc9d9f41bbeaee518497..c55667e0eb65a5978f2b786707afad88f5c30e6e 100644 (file)
@@ -912,10 +912,6 @@ static void scc_std_postreset (struct ata_port *ap, unsigned int *classes)
 {
        DPRINTK("ENTER\n");
 
-       /* re-enable interrupts */
-       if (!ap->ops->error_handler)
-               ap->ops->irq_on(ap);
-
        /* is double-select really necessary? */
        if (classes[0] != ATA_DEV_NONE)
                ap->ops->dev_select(ap, 1);