]> err.no Git - linux-2.6/commitdiff
ide: use drive->select.all for REQ_TYPE_ATA_TASK in execute_drive_cmd()
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 13 Nov 2007 21:09:15 +0000 (22:09 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 13 Nov 2007 21:09:15 +0000 (22:09 +0100)
Use drive->select.all for REQ_TYPE_ATA_TASK requests in execute_drive_cmd()
(the obsolete bits 7 and 5 of the Device register need to be set).

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-io.c

index 755011827afacf8d67fcf174662779b2c0ddfe3b..db22d1ff4e559ff1eb2652de98b23e5c6ae22267 100644 (file)
@@ -885,7 +885,6 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t *drive,
                return do_rw_taskfile(drive, args);
        } else if (rq->cmd_type == REQ_TYPE_ATA_TASK) {
                u8 *args = rq->buffer;
-               u8 sel;
  
                if (!args)
                        goto done;
@@ -903,10 +902,7 @@ static ide_startstop_t execute_drive_cmd (ide_drive_t *drive,
                hwif->OUTB(args[3], IDE_SECTOR_REG);
                hwif->OUTB(args[4], IDE_LCYL_REG);
                hwif->OUTB(args[5], IDE_HCYL_REG);
-               sel = (args[6] & ~0x10);
-               if (drive->select.b.unit)
-                       sel |= 0x10;
-               hwif->OUTB(sel, IDE_SELECT_REG);
+               hwif->OUTB((args[6] & 0xEF)|drive->select.all, IDE_SELECT_REG);
                ide_cmd(drive, args[0], args[2], &drive_cmd_intr);
                return ide_started;
        } else if (rq->cmd_type == REQ_TYPE_ATA_CMD) {