]> err.no Git - linux-2.6/commitdiff
[SCSI] qla2xxx: Correct ISP84XX verify-chip response handling.
authorAndrew Vasquez <andrew.vasquez@qlogic.com>
Thu, 24 Apr 2008 22:21:24 +0000 (15:21 -0700)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sun, 27 Apr 2008 17:19:58 +0000 (12:19 -0500)
Earlier code could trigger an infinite-retry if 1st invocation
returned a non-CS_COMPLETE status.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/qla2xxx/qla_mbx.c

index 7d0a8a4c77196ea302262dcfc2d61f0d6d8931b2..a9cb8291f58efc5f3332dd8c8b0d000ddf056443 100644 (file)
@@ -2982,8 +2982,8 @@ qla84xx_verify_chip(struct scsi_qla_host *ha, uint16_t *status)
        /* We update the firmware with only one data sequence. */
        options |= VCO_END_OF_DATA;
 
-       retry = 0;
        do {
+               retry = 0;
                memset(mn, 0, sizeof(*mn));
                mn->p.req.entry_type = VERIFY_CHIP_IOCB_TYPE;
                mn->p.req.entry_count = 1;