]> err.no Git - linux-2.6/commitdiff
pcmcia: check for pointer instead of pointer address
authorDominik Brodowski <linux@dominikbrodowski.net>
Sat, 14 Jun 2008 16:51:06 +0000 (18:51 +0200)
committerDominik Brodowski <linux@dominikbrodowski.net>
Tue, 24 Jun 2008 13:33:41 +0000 (15:33 +0200)
Bug noted by Michael Buesch: checking for the pointer address is always true.
This didn't matter much, for the very first check in pcmcia_release_window()
was for the pointer pointing to something, and the return value is ignored
here. Nonetheless, fix it.

CC: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
drivers/pcmcia/pcmcia_resource.c

index 1d128fbd1a92d9f4dcdaed4a3065c3365b5fce68..c8f77b889d42ffe6887cbe812a55e0482592eaeb 100644 (file)
@@ -966,7 +966,7 @@ void pcmcia_disable_device(struct pcmcia_device *p_dev) {
        pcmcia_release_configuration(p_dev);
        pcmcia_release_io(p_dev, &p_dev->io);
        pcmcia_release_irq(p_dev, &p_dev->irq);
-       if (&p_dev->win)
+       if (p_dev->win)
                pcmcia_release_window(p_dev->win);
 }
 EXPORT_SYMBOL(pcmcia_disable_device);