]> err.no Git - linux-2.6/commitdiff
[PATCH] v9fs: fix vfs_inode dereference before NULL check
authorEugene Teo <eugene.teo@eugeneteo.net>
Sat, 25 Mar 2006 11:07:27 +0000 (03:07 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Sat, 25 Mar 2006 16:22:54 +0000 (08:22 -0800)
__getname, which in turn will call kmem_cache_alloc, may return NULL.

Coverity bug #977

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/9p/vfs_inode.c

index dc67f83d0dae785732ea1aa469ace94d3d987f2f..4cbfb714c6e437a91e260e9f9acd19a74dc8dafb 100644 (file)
@@ -1244,6 +1244,8 @@ v9fs_vfs_mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t rdev)
                return -EINVAL;
 
        name = __getname();
+       if (!name)
+               return -ENOMEM;
        /* build extension */
        if (S_ISBLK(mode))
                sprintf(name, "b %u %u", MAJOR(rdev), MINOR(rdev));