]> err.no Git - linux-2.6/commitdiff
[ALSA] Fix misuse of __list_add() in seq_ports.c
authorTakashi Iwai <tiwai@suse.de>
Tue, 27 Jun 2006 11:07:04 +0000 (13:07 +0200)
committerJaroslav Kysela <perex@suse.cz>
Wed, 28 Jun 2006 17:31:00 +0000 (19:31 +0200)
seq_ports.c::snd_seq_delete_all_ports() uses __list_add() to replace the
whole list entries.  This results in BUG() with recent FC5 kernel due to
a sanity check in __list_add().
The patch fixes this misue of __list_add() by using standard macros
instead (although a bit more code is needed).

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jaroslav Kysela <perex@suse.cz>
sound/core/seq/seq_ports.c

index 334579a9f268b692178ee301ec3103c4072d8981..d467b4f0ff2b18d50dae96e813a686f7a28821e6 100644 (file)
@@ -322,10 +322,8 @@ int snd_seq_delete_all_ports(struct snd_seq_client *client)
        mutex_lock(&client->ports_mutex);
        write_lock_irqsave(&client->ports_lock, flags);
        if (! list_empty(&client->ports_list_head)) {
-               __list_add(&deleted_list,
-                          client->ports_list_head.prev,
-                          client->ports_list_head.next);
-               INIT_LIST_HEAD(&client->ports_list_head);
+               list_add(&deleted_list, &client->ports_list_head);
+               list_del_init(&client->ports_list_head);
        } else {
                INIT_LIST_HEAD(&deleted_list);
        }