]> err.no Git - linux-2.6/commitdiff
x86: add debug warnings to early_ioremap()
authorIngo Molnar <mingo@elte.hu>
Wed, 30 Jan 2008 12:33:45 +0000 (13:33 +0100)
committerIngo Molnar <mingo@elte.hu>
Wed, 30 Jan 2008 12:33:45 +0000 (13:33 +0100)
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/mm/ioremap_32.c

index 63f76ecae44ca580b38b39163d91a65654023e73..4bcd5e065df4b990904ff290b07c9a9946315b1b 100644 (file)
@@ -306,12 +306,15 @@ void __init *early_ioremap(unsigned long phys_addr, unsigned long size)
 
        /* Don't allow wraparound or zero size */
        last_addr = phys_addr + size - 1;
-       if (!size || last_addr < phys_addr)
+       if (!size || last_addr < phys_addr) {
+               WARN_ON(1);
                return NULL;
+       }
 
-       if (nesting >= FIX_BTMAPS_NESTING)
+       if (nesting >= FIX_BTMAPS_NESTING) {
+               WARN_ON(1);
                return NULL;
-
+       }
        early_ioremap_nested++;
        /*
         * Mappings have to be page-aligned
@@ -324,8 +327,10 @@ void __init *early_ioremap(unsigned long phys_addr, unsigned long size)
         * Mappings have to fit in the FIX_BTMAP area.
         */
        nrpages = size >> PAGE_SHIFT;
-       if (nrpages > NR_FIX_BTMAPS)
+       if (nrpages > NR_FIX_BTMAPS) {
+               WARN_ON(1);
                return NULL;
+       }
 
        /*
         * Ok, go for it..
@@ -351,11 +356,13 @@ void __init early_iounmap(void *addr, unsigned long size)
        unsigned int nesting;
 
        nesting = --early_ioremap_nested;
+       WARN_ON(nesting < 0);
 
        virt_addr = (unsigned long)addr;
-       if (virt_addr < fix_to_virt(FIX_BTMAP_BEGIN))
+       if (virt_addr < fix_to_virt(FIX_BTMAP_BEGIN)) {
+               WARN_ON(1);
                return;
-
+       }
        offset = virt_addr & ~PAGE_MASK;
        nrpages = PAGE_ALIGN(offset + size - 1) >> PAGE_SHIFT;