]> err.no Git - linux-2.6/commitdiff
[IPV4] fib_hash: fix duplicated route issue
authorJoonwoo Park <joonwpark81@gmail.com>
Fri, 18 Jan 2008 11:44:48 +0000 (03:44 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jan 2008 04:31:37 +0000 (20:31 -0800)
http://bugzilla.kernel.org/show_bug.cgi?id=9493

The fib allows making identical routes with 'ip route replace'.
This patch makes the fib return -EEXIST if replacement would cause duplication.

Signed-off-by: Joonwoo Park <joonwpark81@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_hash.c

index 527a6e0af5b60eb48b9e15459e8877db10c29db8..99071d79c5e75f4ef411154b16e8776297d2b257 100644 (file)
@@ -444,6 +444,9 @@ static int fn_hash_insert(struct fib_table *tb, struct fib_config *cfg)
                        struct fib_info *fi_drop;
                        u8 state;
 
+                       if (fi->fib_treeref > 1)
+                               goto out;
+
                        write_lock_bh(&fib_hash_lock);
                        fi_drop = fa->fa_info;
                        fa->fa_info = fi;