]> err.no Git - linux-2.6/commitdiff
[XFRM]: xfrm_user: fix selector family initialization
authorPatrick McHardy <kaber@trash.net>
Wed, 9 Apr 2008 22:08:24 +0000 (15:08 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Apr 2008 22:08:24 +0000 (15:08 -0700)
Commit df9dcb45 ([IPSEC]: Fix inter address family IPsec tunnel handling)
broke openswan by removing the selector initialization for tunnel mode
in case it is uninitialized.

This patch restores the initialization, fixing openswan, but probably
breaking inter-family tunnels again (unknown since the patch author
disappeared). The correct thing for inter-family tunnels is probably
to simply initialize the selector family explicitly.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_user.c

index 5d96f2728dc60f48a337c2c1ff9839ba99184736..019d21de19b3222b8983fa65537e909715eb63e3 100644 (file)
@@ -288,7 +288,7 @@ static void copy_from_user_state(struct xfrm_state *x, struct xfrm_usersa_info *
        memcpy(&x->props.saddr, &p->saddr, sizeof(x->props.saddr));
        x->props.flags = p->flags;
 
-       if (x->props.mode == XFRM_MODE_TRANSPORT)
+       if (!x->sel.family)
                x->sel.family = p->family;
 
 }