]> err.no Git - linux-2.6/commitdiff
[PATCH] for_each_possible_cpu: sh
authorKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Fri, 31 Mar 2006 10:30:02 +0000 (02:30 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 31 Mar 2006 20:18:50 +0000 (12:18 -0800)
for_each_cpu() actually iterates across all possible CPUs.  We've had mistakes
in the past where people were using for_each_cpu() where they should have been
iterating across only online or present CPUs.  This is inefficient and
possibly buggy.

We're renaming for_each_cpu() to for_each_possible_cpu() to avoid this in the
future.

This patch replaces for_each_cpu with for_each_possible_cpu.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Kazumoto Kojima <kkojima@rr.iij4u.or.jp>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/sh/kernel/setup.c

index 7ee4ca203616fee32ae01be36eab00ec2cab026a..bb229ef030f3cbf70c5afa777cd50e194fed6025 100644 (file)
@@ -401,7 +401,7 @@ static int __init topology_init(void)
 {
        int cpu_id;
 
-       for_each_cpu(cpu_id)
+       for_each_possible_cpu(cpu_id)
                register_cpu(&cpu[cpu_id], cpu_id, NULL);
 
        return 0;