]> err.no Git - linux-2.6/commitdiff
ath5k: fix recursive locking in ath5k_beacon_update
authorBob Copeland <me@bobcopeland.com>
Fri, 18 Jul 2008 15:11:21 +0000 (11:11 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 29 Jul 2008 20:55:04 +0000 (16:55 -0400)
ath5k_beacon_update takes sc->lock upon entry.  However, it is only
called from within ath5k_config_interface, which already holds the lock.
Remove the unnecessary locking from ath5k_beacon_update.

Signed-off-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath5k/base.c

index 359795d8b482e323f4d805264d5c86aa8570fbc8..3285032727b3461543d81ea78c82b8c0367d2bc1 100644 (file)
@@ -3065,8 +3065,6 @@ ath5k_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb)
 
        ath5k_debug_dump_skb(sc, skb, "BC  ", 1);
 
-       mutex_lock(&sc->lock);
-
        if (sc->opmode != IEEE80211_IF_TYPE_IBSS) {
                ret = -EIO;
                goto end;
@@ -3083,7 +3081,6 @@ ath5k_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb)
        }
 
 end:
-       mutex_unlock(&sc->lock);
        return ret;
 }