]> err.no Git - linux-2.6/commitdiff
[ARM] 4117/1: S3C2412: Fix writel() usage in selection code
authorBen Dooks <ben-linux@fluff.org>
Sun, 28 Jan 2007 23:11:29 +0000 (00:11 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Mon, 29 Jan 2007 10:09:17 +0000 (10:09 +0000)
The S3C2412 DMA selection code has the
arguments to writel() the wrong way around.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-s3c2410/s3c2412-dma.c

index fe71a8fdb87cd55eadc2fe751e32bb05a336a392..138f726ac6bfa8efcbd38bae070fb83ee5ecee40 100644 (file)
@@ -133,8 +133,8 @@ static struct s3c24xx_dma_map __initdata s3c2412_dma_mappings[] = {
 static void s3c2412_dma_select(struct s3c2410_dma_chan *chan,
                               struct s3c24xx_dma_map *map)
 {
-       writel(chan->regs + S3C2412_DMA_DMAREQSEL,
-              map->channels[0] | S3C2412_DMAREQSEL_HW);
+       writel(map->channels[0] | S3C2412_DMAREQSEL_HW,
+              chan->regs + S3C2412_DMA_DMAREQSEL);
 }
 
 static struct s3c24xx_dma_selection __initdata s3c2412_dma_sel = {