]> err.no Git - linux-2.6/commitdiff
[DCCP]: Fix leak in net/dccp/ipv4.c
authorEric Sesterhenn <snakebyte@gmx.de>
Mon, 10 Apr 2006 23:43:03 +0000 (16:43 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 12 Apr 2006 00:21:06 +0000 (17:21 -0700)
we dont free req if we cant parse the options.
This fixes coverity bug id #1046

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/dccp/ipv4.c

index 29047995c6957595bf40bdffbc8ad940291ba174..f2c011fd2ba128f92757aa816da604804d99394f 100644 (file)
@@ -498,7 +498,7 @@ int dccp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
                goto drop;
 
        if (dccp_parse_options(sk, skb))
-               goto drop;
+               goto drop_and_free;
 
        dccp_openreq_init(req, &dp, skb);