]> err.no Git - linux-2.6/commitdiff
Fix sata_via write errors on PATA drive connected to VT6421
authorOndrej Zary <linux@rainbow-software.org>
Fri, 31 Aug 2007 22:55:21 +0000 (00:55 +0200)
committerJeff Garzik <jeff@garzik.org>
Sat, 1 Sep 2007 10:52:18 +0000 (06:52 -0400)
I think that I've found and fixed the problem. There is a copy/paste bug in
vt6421_set_dma_mode() function which causes wrong values to be written to
PATA_UDMA_TIMING register.

This patch fixes a copy/paste bug that breaks DMA modes on VT6421 PATA port.

Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/sata_via.c

index a4e631766eee3525e89591c905ce434f057e4663..57fd30de8f0dda9c811a8fd377bc1eb40f4434f2 100644 (file)
@@ -371,7 +371,7 @@ static void vt6421_set_dma_mode(struct ata_port *ap, struct ata_device *adev)
 {
        struct pci_dev *pdev = to_pci_dev(ap->host->dev);
        static const u8 udma_bits[] = { 0xEE, 0xE8, 0xE6, 0xE4, 0xE2, 0xE1, 0xE0, 0xE0 };
-       pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->pio_mode - XFER_UDMA_0]);
+       pci_write_config_byte(pdev, PATA_UDMA_TIMING, udma_bits[adev->dma_mode - XFER_UDMA_0]);
 }
 
 static const unsigned int svia_bar_sizes[] = {