]> err.no Git - linux-2.6/commitdiff
IB/ipath: Fix time comparison to use time_after_eq()
authorRobert P. J. Day <rpjday@crashcourse.ca>
Thu, 17 Apr 2008 04:09:28 +0000 (21:09 -0700)
committerRoland Dreier <rolandd@cisco.com>
Thu, 17 Apr 2008 04:09:28 +0000 (21:09 -0700)
Raw comparison against jiffies will fail if jiffies wraps, although
since ipath currently only supports 64-bit architectures, this is rather
far-fetched.  Still, it's better to use time_after_eq().

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ipath/ipath_mad.c

index 30b2f44406b1d23530863f11278d99f2321386fb..babcc09c832cc4a9f51e5c291319e5865c65c22c 100644 (file)
@@ -1397,7 +1397,8 @@ static int process_subn(struct ib_device *ibdev, int mad_flags,
        }
 
        /* Is the mkey in the process of expiring? */
-       if (dev->mkey_lease_timeout && jiffies >= dev->mkey_lease_timeout) {
+       if (dev->mkey_lease_timeout &&
+           time_after_eq(jiffies, dev->mkey_lease_timeout)) {
                /* Clear timeout and mkey protection field. */
                dev->mkey_lease_timeout = 0;
                dev->mkeyprot = 0;