]> err.no Git - linux-2.6/commitdiff
IB/mthca: Fix lid used for sending traps
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Tue, 19 Sep 2006 08:13:24 +0000 (11:13 +0300)
committerRoland Dreier <rolandd@cisco.com>
Fri, 22 Sep 2006 22:17:17 +0000 (15:17 -0700)
The SM LID used to send traps to is incorrectly set to port LID.  This
is a regression from 2.6.17 -- after a PortInfo MAD is received, no
traps are sent to the SM LID.  The traps go to the loopback interface
instead, and are dropped there.  The SM LID should be taken from the
sm_lid of the PortInfo response.

The bug was introduced by commit 12bbb2b7be7f5564952ebe0196623e97464b8ac5:
IB/mthca: Add client reregister event generation

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/mthca/mthca_mad.c

index d9bc030bcccc78627f434a226f199110dafefa15..45e106f148071c95a93125beb4e20f878988f0ec 100644 (file)
@@ -119,7 +119,7 @@ static void smp_snoop(struct ib_device *ibdev,
 
                        mthca_update_rate(to_mdev(ibdev), port_num);
                        update_sm_ah(to_mdev(ibdev), port_num,
-                                    be16_to_cpu(pinfo->lid),
+                                    be16_to_cpu(pinfo->sm_lid),
                                     pinfo->neighbormtu_mastersmsl & 0xf);
 
                        event.device           = ibdev;