]> err.no Git - linux-2.6/commitdiff
[ARM] Orion: remove error printks in ->map_irq() implementations
authorLennert Buytenhek <buytenh@wantstofly.org>
Fri, 6 Jun 2008 10:32:59 +0000 (12:32 +0200)
committerLennert Buytenhek <buytenh@marvell.com>
Sun, 22 Jun 2008 20:44:47 +0000 (22:44 +0200)
If all PCI devices are working as expected, the error printks in the
various implementations of ->map_irq() doesn't really provide any
useful info.  And if something is not working as expected, turning
on pci=debug gives you more useful information than the printk calls
in ->map_irq(), since the former also tells you which devices _did_
get IRQs successfully assigned.  Therefore, delete these printks
entirely.

Spotted by Russell King.

Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Acked-by: Russell King <linux@arm.linux.org.uk>
arch/arm/mach-orion5x/dns323-setup.c
arch/arm/mach-orion5x/kurobox_pro-setup.c

index 05ce660487411913cfcf63a73b42ad3ea6c13634..ad810aa5fff53615ae7431e5f16c6d2ff9cbeaed 100644 (file)
@@ -53,8 +53,6 @@ static int __init dns323_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
        if (irq != -1)
                return irq;
 
-       pr_err("%s: requested mapping for unknown device\n", __func__);
-
        return -1;
 }
 
index f0997a7ba6d2e14161607760d337ec1bedaf0b0a..b8414f6e0e83ff763502c109f1526eabca3f5690 100644 (file)
@@ -131,8 +131,6 @@ static int __init kurobox_pro_pci_map_irq(struct pci_dev *dev, u8 slot, u8 pin)
        /*
         * PCI isn't used on the Kuro
         */
-       printk(KERN_ERR "kurobox_pro_pci_map_irq failed, unknown bus\n");
-
        return -1;
 }