]> err.no Git - linux-2.6/commitdiff
[CIFS] Fix improper endian conversion of ACL subauth field
authorShirish Pargaonkar <shirishp@gmail.com>
Thu, 24 Jul 2008 14:53:20 +0000 (14:53 +0000)
committerSteve French <sfrench@us.ibm.com>
Thu, 24 Jul 2008 14:53:20 +0000 (14:53 +0000)
In mode_to_acl when converting a Unix mode to a Windows ACL
the subauth fields of the SID in the ACL were translated
incorrectly on bigendian architectures

Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/cifsacl.c

index 0e9fc2ba90ee23998c33e1125b6186c8f8150ac5..18faf65b91148366bffc08c1d9a1d14ba22ceecd 100644 (file)
@@ -169,8 +169,7 @@ static void copy_sec_desc(const struct cifs_ntsd *pntsd,
        for (i = 0; i < 6; i++)
                ngroup_sid_ptr->authority[i] = group_sid_ptr->authority[i];
        for (i = 0; i < 5; i++)
-               ngroup_sid_ptr->sub_auth[i] =
-                               cpu_to_le32(group_sid_ptr->sub_auth[i]);
+               ngroup_sid_ptr->sub_auth[i] = group_sid_ptr->sub_auth[i];
 
        return;
 }