]> err.no Git - linux-2.6/commitdiff
[SPARC]: Add missing of_node_put
authorJulia Lawall <julia@diku.dk>
Tue, 4 Dec 2007 08:33:07 +0000 (00:33 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 5 Dec 2007 13:38:00 +0000 (05:38 -0800)
There should be an of_node_put when breaking out of a loop that iterates
using for_each_node_by_type.

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/devices.c

index af90a5f9ab5751a6ee19161221b198c55f9ae8b8..b240b8863fd044153319340f3960fa87e88cd6ba 100644 (file)
@@ -62,8 +62,10 @@ static int __cpu_find_by(int (*compare)(int, int, void *), void *compare_arg,
                int err = check_cpu_node(dp->node, &cur_inst,
                                         compare, compare_arg,
                                         prom_node, mid);
-               if (!err)
+               if (!err) {
+                       of_node_put(dp);
                        return 0;
+               }
        }
 
        return -ENODEV;