]> err.no Git - linux-2.6/commitdiff
libata: fix hw_sata_spd_limit initialization
authorTejun Heo <htejun@gmail.com>
Wed, 6 Jun 2007 07:35:55 +0000 (16:35 +0900)
committerJeff Garzik <jeff@garzik.org>
Sun, 10 Jun 2007 02:40:28 +0000 (22:40 -0400)
hw_sata_spd_limit used to be incorrectly initialized to zero instead
of UINT_MAX if SPD is zero in SControl register.  This breaks PHY
speed down.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c

index e7937166a8ba5ad837f67e785d071cf5c2dc65c4..bf8d3b8c171df34b48fd4acc43bb6c9c7b30e16c 100644 (file)
@@ -6317,7 +6317,8 @@ int ata_host_register(struct ata_host *host, struct scsi_host_template *sht)
                /* init sata_spd_limit to the current value */
                if (sata_scr_read(ap, SCR_CONTROL, &scontrol) == 0) {
                        int spd = (scontrol >> 4) & 0xf;
-                       ap->hw_sata_spd_limit &= (1 << spd) - 1;
+                       if (spd)
+                               ap->hw_sata_spd_limit &= (1 << spd) - 1;
                }
                ap->sata_spd_limit = ap->hw_sata_spd_limit;