]> err.no Git - linux-2.6/commitdiff
drivers/usb/misc/auerswald: fix status check, remove redundant check
authorJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 05:08:29 +0000 (01:08 -0400)
committerJeff Garzik <jeff@garzik.org>
Tue, 17 Jul 2007 20:18:00 +0000 (16:18 -0400)
1) We should only set 'actual_length' output variable if usb length is
known to be good.

2) No need to check actual_length for NULL.  The only caller always
passes non-NULL value.

Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/usb/misc/auerswald.c

index 1fd5fc220cd7ee9ac81c08af66e10466e5bb3821..3e22b2ff9e7406aa0c5b170efb814cd183f07450 100644 (file)
@@ -630,7 +630,7 @@ static int auerchain_start_wait_urb (pauerchain_t acp, struct urb *urb, int time
        } else
                status = urb->status;
 
-       if (actual_length)
+       if (status >= 0)
                *actual_length = urb->actual_length;
 
        return status;