]> err.no Git - linux-2.6/commitdiff
ata/sata_fsl: Remove unused variable in sata_fsl_probe
authorJohann Felix Soden <johfel@users.sourceforge.net>
Sun, 6 Apr 2008 13:10:54 +0000 (15:10 +0200)
committerJeff Garzik <jeff@garzik.org>
Wed, 9 Apr 2008 05:06:37 +0000 (01:06 -0400)
In sata_fsl_probe memory is allocated but never used or deallocated.
Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=10404
Thanks to Daniel Marjamäki for the bug report.

Reported-by: Daniel Marjamäki <danielm77@spray.se>
Signed-off-by: Johann Felix Soden <johfel@users.sourceforge.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/sata_fsl.c

index 4c198551154825528cbcc637f9bed20b465b46c5..9d1e3cad4aa989ce021ae2511e0c9112e80278d6 100644 (file)
@@ -1256,7 +1256,6 @@ static int sata_fsl_probe(struct of_device *ofdev,
        void __iomem *ssr_base = NULL;
        void __iomem *csr_base = NULL;
        struct sata_fsl_host_priv *host_priv = NULL;
-       struct resource *r;
        int irq;
        struct ata_host *host;
 
@@ -1266,8 +1265,6 @@ static int sata_fsl_probe(struct of_device *ofdev,
        dev_printk(KERN_INFO, &ofdev->dev,
                   "Sata FSL Platform/CSB Driver init\n");
 
-       r = kmalloc(sizeof(struct resource), GFP_KERNEL);
-
        hcr_base = of_iomap(ofdev->node, 0);
        if (!hcr_base)
                goto error_exit_with_cleanup;