]> err.no Git - linux-2.6/commitdiff
[PATCH] libata: kill illegal kfree(id)
authorTejun Heo <htejun@gmail.com>
Tue, 28 Feb 2006 08:38:10 +0000 (17:38 +0900)
committerJeff Garzik <jeff@garzik.org>
Wed, 1 Mar 2006 19:48:42 +0000 (14:48 -0500)
Kill kfree(id) in failure path of ata_dev_read_id().  id is not
dynamically allocated yet.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/scsi/libata-core.c

index 17c1df435cc8ab89b0a6f0c79c824de07dc3edd5..e34b421eb2a30cf94fb3d9eec25662c7bd5ebc76 100644 (file)
@@ -1040,7 +1040,6 @@ static int ata_dev_read_id(struct ata_port *ap, struct ata_device *dev,
  err_out:
        printk(KERN_WARNING "ata%u: dev %u failed to IDENTIFY (%s)\n",
               ap->id, dev->devno, reason);
-       kfree(id);
        return rc;
 }