]> err.no Git - linux-2.6/commitdiff
PCI: fix rpadlpar pci hotplug driver sysfs usage
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 30 May 2008 03:39:12 +0000 (13:39 +1000)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Fri, 30 May 2008 16:50:46 +0000 (09:50 -0700)
When Greg "fixed" the sysfs usage of that driver a while back, he seem
to have introduced a bug where the quotes are added around the name of
our specific sysfs files, thus breaking the user space tool.

This fixes it. Tested DLPAR operations on a POWER6 machine successfully.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/rpadlpar_sysfs.c

index e32148a8fa125e0d6d7bcf9d017d0db0015d6329..779c5db71be46150bc5c34896bea57dc23697b9e 100644 (file)
 #include "rpadlpar.h"
 
 #define DLPAR_KOBJ_NAME       "control"
-#define ADD_SLOT_ATTR_NAME    "add_slot"
-#define REMOVE_SLOT_ATTR_NAME "remove_slot"
+
+/* Those two have no quotes because they are passed to __ATTR() which
+ * stringifies the argument (yuck !)
+ */
+#define ADD_SLOT_ATTR_NAME    add_slot
+#define REMOVE_SLOT_ATTR_NAME remove_slot
 
 #define MAX_DRC_NAME_LEN 64