]> err.no Git - linux-2.6/commitdiff
[PATCH] i2c-ixp4xx: fix ") != 0))" typo
authorAlexey Dobriyan <adobriyan@openvz.org>
Sun, 19 Nov 2006 06:19:36 +0000 (22:19 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Mon, 20 Nov 2006 17:42:05 +0000 (09:42 -0800)
i2c_bit_add_bus() returns -E;
-E != 0 => err = 1
probe fails with positive error code

Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
Cc: Deepak Saxena <dsaxena@mvista.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/i2c/busses/i2c-ixp4xx.c

index 1ce01fb0ac09f1139d04480fb9824f738e44f81f..05fffb9415a2d9566afe73ae930be4267ec735d1 100644 (file)
@@ -137,7 +137,8 @@ static int ixp4xx_i2c_probe(struct platform_device *plat_dev)
        gpio_line_set(gpio->scl_pin, 0);
        gpio_line_set(gpio->sda_pin, 0);
 
-       if ((err = i2c_bit_add_bus(&drv_data->adapter) != 0)) {
+       err = i2c_bit_add_bus(&drv_data->adapter);
+       if (err != 0)
                printk(KERN_ERR "ERROR: Could not install %s\n", plat_dev->dev.bus_id);
 
                kfree(drv_data);