]> err.no Git - linux-2.6/commitdiff
NFSv4: rpc_mkpipe creating socket inodes w/out sk buffers
authorSteve Dickson <steved@redhat.com>
Wed, 6 Sep 2006 15:51:21 +0000 (11:51 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Sat, 23 Sep 2006 03:25:05 +0000 (23:25 -0400)
This patch stop rpc_mkpipe from create S_IFSOCK nodes what don't
have associated sk buffers attached (which causes SELinux to oops
during NFSv4 mounts). Instead the S_IFIFO mode bit is set which
probably make more sense and seems to work just fine during
my connectathon and fsx testing...

Signed-off-by: Steve Dickson <steved@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/rpc_pipe.c

index 11ec12a09d704cc9e81c474e43dcf83fe6aab21c..dfa504fe383f0b56d69aecc8ce5031609e16d91f 100644 (file)
@@ -720,7 +720,7 @@ rpc_mkpipe(struct dentry *parent, const char *name, void *private, struct rpc_pi
        if (IS_ERR(dentry))
                return dentry;
        dir = parent->d_inode;
-       inode = rpc_get_inode(dir->i_sb, S_IFSOCK | S_IRUSR | S_IWUSR);
+       inode = rpc_get_inode(dir->i_sb, S_IFIFO | S_IRUSR | S_IWUSR);
        if (!inode)
                goto err_dput;
        inode->i_ino = iunique(dir->i_sb, 100);