]> err.no Git - linux-2.6/commitdiff
V4L/DVB: Don't access input_dev->private directly
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Sun, 4 Nov 2007 04:50:19 +0000 (00:50 -0400)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 21 Jan 2008 06:11:07 +0000 (01:11 -0500)
Drivers should use input_{get|set}_drvdata() instead of accessing
input_dev->provate directly, but since these drivers do not actually
use the data stored there we can simply remove the assignments.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/usbvideo/konicawc.c
drivers/media/video/usbvideo/quickcam_messenger.c

index 3e93f80587708f2f118d150c8c9a0ac3cc2c3208..719b17ce83f832c87bf2ce50590af74d0a266bc0 100644 (file)
@@ -241,8 +241,6 @@ static void konicawc_register_input(struct konicawc *cam, struct usb_device *dev
        input_dev->evbit[0] = BIT_MASK(EV_KEY);
        input_dev->keybit[BIT_WORD(BTN_0)] = BIT_MASK(BTN_0);
 
-       input_dev->private = cam;
-
        error = input_register_device(cam->input);
        if (error) {
                warn("Failed to register camera's input device, err: %d\n",
index d847273eeba0c247c4f707a4fed3b00feef04b3e..6438bc1f506deeddfa8e777b6069575c58053fe8 100644 (file)
@@ -105,8 +105,6 @@ static void qcm_register_input(struct qcm *cam, struct usb_device *dev)
        input_dev->evbit[0] = BIT_MASK(EV_KEY);
        input_dev->keybit[BIT_WORD(BTN_0)] = BIT_MASK(BTN_0);
 
-       input_dev->private = cam;
-
        error = input_register_device(cam->input);
        if (error) {
                warn("Failed to register camera's input device, err: %d\n",