]> err.no Git - linux-2.6/commitdiff
[PATCH] ppc64: simplify nvram partition scanning code
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Jun 2005 10:33:49 +0000 (20:33 +1000)
committerPaul Mackerras <paulus@samba.org>
Tue, 28 Jun 2005 10:33:49 +0000 (20:33 +1000)
Convert nvram_create_os_partition to use list_for_each_entry
instead of list_for_each, as this reduces the code size by
two lines.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/ppc64/kernel/nvram.c

index 4e71781a44143e2a4ff65adbea2513c2c559dfc2..4fb1a9f5060deb66b78867755ba31c320afd71b8 100644 (file)
@@ -338,9 +338,8 @@ static int nvram_remove_os_partition(void)
  */
 static int nvram_create_os_partition(void)
 {
-       struct list_head * p;
-       struct nvram_partition *part = NULL;
-       struct nvram_partition *new_part = NULL;
+       struct nvram_partition *part;
+       struct nvram_partition *new_part;
        struct nvram_partition *free_part = NULL;
        int seq_init[2] = { 0, 0 };
        loff_t tmp_index;
@@ -349,8 +348,7 @@ static int nvram_create_os_partition(void)
        
        /* Find a free partition that will give us the maximum needed size 
           If can't find one that will give us the minimum size needed */
-       list_for_each(p, &nvram_part->partition) {
-               part = list_entry(p, struct nvram_partition, partition);
+       list_for_each_entry(part, &nvram_part->partition, partition) {
                if (part->header.signature != NVRAM_SIG_FREE)
                        continue;