]> err.no Git - linux-2.6/commitdiff
i2c-gpio: Fix adapter number
authorDavid Brownell <david-b@pacbell.net>
Sun, 9 Sep 2007 20:29:13 +0000 (22:29 +0200)
committerJean Delvare <khali@hyperion.delvare>
Sun, 9 Sep 2007 20:29:13 +0000 (22:29 +0200)
It turns out that platform_device.id is a "u32" so testing it for being
nonnegative is useless when setting up an i2c bitbang device.  Instead,
do what the platform_bus code does and test it against the value "-1".

Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/busses/i2c-gpio.c

index 025f19423faffee0df8e88cabf67d630e48cc52f..44e1cd21bb0130ae1e4b0251893c451a630c4a6d 100644 (file)
@@ -147,7 +147,7 @@ static int __init i2c_gpio_probe(struct platform_device *pdev)
         * The reason to do so is to avoid sysfs names that only make
         * sense when there are multiple adapters.
         */
-       adap->nr = pdev->id >= 0 ? pdev->id : 0;
+       adap->nr = (pdev->id != -1) ? pdev->id : 0;
        ret = i2c_bit_add_numbered_bus(adap);
        if (ret)
                goto err_add_bus;