]> err.no Git - linux-2.6/commitdiff
fbdev: kill sparse warning in deferred IO
authorAntonino A. Daplas <adaplas@gmail.com>
Tue, 8 May 2007 07:38:44 +0000 (00:38 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Tue, 8 May 2007 18:15:29 +0000 (11:15 -0700)
Kill the following in fb_defio.c:

drivers/video/fb_defio.c:40:43: warning: incorrect type in argument 1 (different address spaces)
drivers/video/fb_defio.c:40:43:    expected void *addr
drivers/video/fb_defio.c:40:43:    got char [noderef] *screen_base<asn:2>

The framebuffer memory of these types of devices are allocated from system
RAM.

Signed-off-by: Antonino Daplas <adaplas@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/video/fb_defio.c

index f963f5f59b73377e7b534c96863cb9a5bd2eb4fa..1a8643f053d87af079ceb8b32e19e19a765892c9 100644 (file)
@@ -32,12 +32,14 @@ static struct page* fb_deferred_io_nopage(struct vm_area_struct *vma,
        unsigned long offset;
        struct page *page;
        struct fb_info *info = vma->vm_private_data;
+       /* info->screen_base is in System RAM */
+       void *screen_base = (void __force *) info->screen_base;
 
        offset = (vaddr - vma->vm_start) + (vma->vm_pgoff << PAGE_SHIFT);
        if (offset >= info->fix.smem_len)
                return NOPAGE_SIGBUS;
 
-       page = vmalloc_to_page(info->screen_base + offset);
+       page = vmalloc_to_page(screen_base + offset);
        if (!page)
                return NOPAGE_OOM;