]> err.no Git - linux-2.6/commitdiff
[PATCH] sched: fix the all pinned logic in load_balance_newidle()
authorSuresh Siddha <suresh.b.siddha@intel.com>
Thu, 19 Jul 2007 19:28:35 +0000 (21:28 +0200)
committerIngo Molnar <mingo@elte.hu>
Thu, 19 Jul 2007 19:28:35 +0000 (21:28 +0200)
nr_moved is not the correct check for triggering all pinned logic. Fix
the all pinned logic in the case of load_balance_newidle().

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c

index e36d99d1ddb13c862380db3e2ef9c77ef94a034e..a35a92ff38fdda8dc02049b90274e80e1b729f65 100644 (file)
@@ -2679,6 +2679,7 @@ load_balance_newidle(int this_cpu, struct rq *this_rq, struct sched_domain *sd)
        unsigned long imbalance;
        int nr_moved = 0;
        int sd_idle = 0;
+       int all_pinned = 0;
        cpumask_t cpus = CPU_MASK_ALL;
 
        /*
@@ -2717,10 +2718,11 @@ redo:
                double_lock_balance(this_rq, busiest);
                nr_moved = move_tasks(this_rq, this_cpu, busiest,
                                        minus_1_or_zero(busiest->nr_running),
-                                       imbalance, sd, CPU_NEWLY_IDLE, NULL);
+                                       imbalance, sd, CPU_NEWLY_IDLE,
+                                       &all_pinned);
                spin_unlock(&busiest->lock);
 
-               if (!nr_moved) {
+               if (unlikely(all_pinned)) {
                        cpu_clear(cpu_of(busiest), cpus);
                        if (!cpus_empty(cpus))
                                goto redo;