]> err.no Git - linux-2.6/commitdiff
[IA64] operator priority fix in acpi_map_lsapic()
authorRoel Kluin <12o3l@tiscali.nl>
Fri, 7 Dec 2007 22:59:30 +0000 (14:59 -0800)
committerTony Luck <tony.luck@intel.com>
Sat, 8 Dec 2007 00:12:30 +0000 (16:12 -0800)
'!' has a higher priority than '&', so as was
this won't test the first bit, but rather evaluates to false for any non-zero
lsapic->lapic_flags.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Tony Luck <tony.luck@intel.com>
arch/ia64/kernel/acpi.c

index 897e2083a3b1b4c77f8dd200d3ab593b377677e8..00b5d08f6da8d67da2f67c9506d1164e72e7e0a7 100644 (file)
@@ -860,7 +860,7 @@ int acpi_map_lsapic(acpi_handle handle, int *pcpu)
        lsapic = (struct acpi_madt_local_sapic *)obj->buffer.pointer;
 
        if ((lsapic->header.type != ACPI_MADT_TYPE_LOCAL_SAPIC) ||
-           (!lsapic->lapic_flags & ACPI_MADT_ENABLED)) {
+           (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))) {
                kfree(buffer.pointer);
                return -EINVAL;
        }