]> err.no Git - linux-2.6/commitdiff
ide: remove IDE_HFLAG_CY82C693 host flag
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sat, 26 Apr 2008 15:36:38 +0000 (17:36 +0200)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Sat, 26 Apr 2008 15:36:38 +0000 (17:36 +0200)
Sergei suggested that it shouldn't be necessary + it had no effect
anyway since ide_id_dma_bug() is called earlier in ide_tune_dma().

Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/ide-dma.c
drivers/ide/pci/cy82c693.c
include/linux/ide.h

index d61e5788d310f06dc42c12d7f7cd507e8fa10a39..aaece2c06c9d505be905cdf437095496e13eb0a8 100644 (file)
@@ -703,14 +703,8 @@ static int ide_tune_dma(ide_drive_t *drive)
 
        speed = ide_max_dma_mode(drive);
 
-       if (!speed) {
-                /* is this really correct/needed? */
-               if ((hwif->host_flags & IDE_HFLAG_CY82C693) &&
-                   ide_dma_good_drive(drive))
-                       return 1;
-               else
-                       return 0;
-       }
+       if (!speed)
+               return 0;
 
        if (hwif->host_flags & IDE_HFLAG_NO_SET_MODE)
                return 1;
index f68b89a05823cd975e6571e875a1eecc5d1c3328..833fa4de30818c535b9fea2fe2950d12f8575131 100644 (file)
@@ -410,7 +410,7 @@ static const struct ide_port_info cy82c693_chipset __devinitdata = {
        .init_iops      = init_iops_cy82c693,
        .init_hwif      = init_hwif_cy82c693,
        .chipset        = ide_cy82c693,
-       .host_flags     = IDE_HFLAG_SINGLE | IDE_HFLAG_CY82C693,
+       .host_flags     = IDE_HFLAG_SINGLE,
        .pio_mask       = ATA_PIO4,
        .swdma_mask     = ATA_SWDMA2,
        .mwdma_mask     = ATA_MWDMA2,
index 4997751591a3e3ccf6233327d26db10f397ebe12..cd8deba68cb28c93d63789acbddcfe016122a609 100644 (file)
@@ -1085,8 +1085,6 @@ enum {
        /* unmask IRQs */
        IDE_HFLAG_UNMASK_IRQS           = (1 << 25),
        IDE_HFLAG_ABUSE_SET_DMA_MODE    = (1 << 26),
-       /* host is CY82C693 */
-       IDE_HFLAG_CY82C693              = (1 << 27),
        /* force host out of "simplex" mode */
        IDE_HFLAG_CLEAR_SIMPLEX         = (1 << 28),
        /* DSC overlap is unsupported */