]> err.no Git - linux-2.6/commitdiff
V4L/DVB (4704): SAA713x: fixed compile warning in SECAM fixup
authorHartmut Hackmann <hartmut.hackmann@t-online.de>
Tue, 3 Oct 2006 00:00:32 +0000 (21:00 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 4 Oct 2006 11:06:00 +0000 (08:06 -0300)
The variable fixup could be used uninitialized.

Signed-off-by: Hartmut Hackmann <hartmut.hackmann@t-online.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/saa7134/saa7134-video.c

index 557530aef946620bbaad2f4fecf196a3be9ea82f..203302f21827e5104e8b7d1b2485afbb369b76c2 100644 (file)
@@ -1820,15 +1820,18 @@ static int video_do_ioctl(struct inode *inode, struct file *file,
                                        break;
                if (i == TVNORMS)
                        return -EINVAL;
-               if (*id & V4L2_STD_SECAM) {
-                       if (secam[0] == 'L' || secam[0] == 'l')
+               if ((*id & V4L2_STD_SECAM) && (secam[0] != '-')) {
+                       if (secam[0] == 'L' || secam[0] == 'l') {
                                if (secam[1] == 'C' || secam[1] == 'c')
                                        fixup = V4L2_STD_SECAM_LC;
                                else
                                        fixup = V4L2_STD_SECAM_L;
-                       else
+                       } else {
                                if (secam[0] == 'D' || secam[0] == 'd')
                                        fixup = V4L2_STD_SECAM_DK;
+                               else
+                                       fixup = V4L2_STD_SECAM;
+                       }
                        for (i = 0; i < TVNORMS; i++)
                                if (fixup == tvnorms[i].id)
                                        break;