]> err.no Git - linux-2.6/commitdiff
md: the bitmap code needs to use blk_plug_device_unlocked()
authorJens Axboe <jens.axboe@oracle.com>
Fri, 1 Aug 2008 18:32:31 +0000 (20:32 +0200)
committerJens Axboe <jens.axboe@oracle.com>
Fri, 1 Aug 2008 18:32:31 +0000 (20:32 +0200)
It doesn't hold the queue lock, so it's both racey on the queue flags
and thus spews a warning.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
drivers/md/bitmap.c

index 621a272a2c7495b9cd8866ec6bb6d0454d5d1396..7e65bad522cb26456b4b1909d69b7c72e52efb3d 100644 (file)
@@ -1234,7 +1234,7 @@ int bitmap_startwrite(struct bitmap *bitmap, sector_t offset, unsigned long sect
                case 0:
                        bitmap_file_set_bit(bitmap, offset);
                        bitmap_count_page(bitmap,offset, 1);
-                       blk_plug_device(bitmap->mddev->queue);
+                       blk_plug_device_unlocked(bitmap->mddev->queue);
                        /* fall through */
                case 1:
                        *bmc = 2;