]> err.no Git - linux-2.6/commitdiff
[PATCH] x86-64: Always flush all pages in change_page_attr
authorAndi Kleen <ak@suse.de>
Tue, 24 Apr 2007 11:05:37 +0000 (13:05 +0200)
committerAndi Kleen <andi@basil.nowhere.org>
Tue, 24 Apr 2007 11:05:37 +0000 (13:05 +0200)
change_page_attr on x86-64 only flushed the TLB for pages that got
reverted. That's not correct: it has to be flushed in all cases.

This bug was added in some earlier changes.

Just flush all pages for now.

This could be done more efficiently, but for this late in the release
this seem to be the best fix.

Pointed out by Jan Beulich

Signed-off-by: Andi Kleen <ak@suse.de>
arch/x86_64/mm/pageattr.c

index 65c5eaa5990563048b1ac59e04e3dcd645441b5c..081409aa3452bb773f0d6331bd319c6d2b7d231c 100644 (file)
@@ -81,8 +81,8 @@ static void flush_kernel_map(void *arg)
                void *adr = page_address(pg);
                if (cpu_has_clflush)
                        cache_flush_page(adr);
-               __flush_tlb_one(adr);
        }
+       __flush_tlb_all();
 }
 
 static inline void flush_map(struct list_head *l)