]> err.no Git - linux-2.6/commitdiff
[TCP] inet_twdr_hangman: Delete unnecessary memory barrier().
authorDavid S. Miller <davem@sunset.davemloft.net>
Thu, 7 Dec 2006 08:12:30 +0000 (00:12 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 7 Dec 2006 08:12:30 +0000 (00:12 -0800)
As per Ralf Baechle's observations, the schedule_work() call
should give enough of a memory barrier, so the explicit one
here is totally unnecessary.

Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/inet_timewait_sock.c

index 75373f35383fb914684aae1c5b9f7c204b7a5f2f..061fd7a961b809d887a413df42e184841c7e32e8 100644 (file)
@@ -178,7 +178,6 @@ void inet_twdr_hangman(unsigned long data)
        need_timer = 0;
        if (inet_twdr_do_twkill_work(twdr, twdr->slot)) {
                twdr->thread_slots |= (1 << twdr->slot);
-               smp_mb();
                schedule_work(&twdr->twkill_work);
                need_timer = 1;
        } else {