]> err.no Git - linux-2.6/commitdiff
gianfar: Fix typo bug introduced by move to udp_hdr()
authorKumar Gala <galak@kernel.crashing.org>
Fri, 29 Jun 2007 05:12:04 +0000 (00:12 -0500)
committerKumar Gala <galak@kernel.crashing.org>
Fri, 29 Jun 2007 05:12:04 +0000 (00:12 -0500)
In commit 4bedb45203eab92a87b4c863fe2d0cded633427f both the udp and tcp
cases where changed to use udp_hdr() instead of leaving the tcp case
alone and fixing with tcp_hdr().

This ended up causing random behavior with TCP connections because
of looking for tcp_hdr()->check in the wrong place.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
drivers/net/gianfar.c

index 6822bf14267b265ca8c3b0adc0801074b1f37728..1b854bf07b09fec79f6abfa5b58f70b6ef91d1be 100644 (file)
@@ -944,7 +944,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb)
                flags |= TXFCB_UDP;
                fcb->phcs = udp_hdr(skb)->check;
        } else
-               fcb->phcs = udp_hdr(skb)->check;
+               fcb->phcs = tcp_hdr(skb)->check;
 
        /* l3os is the distance between the start of the
         * frame (skb->data) and the start of the IP hdr.