]> err.no Git - linux-2.6/commitdiff
[PATCH] Uninitialized variable in drivers/net/wan/syncppp.c
authorEric Sesterhenn <snakebyte@gmx.de>
Fri, 29 Sep 2006 09:01:32 +0000 (02:01 -0700)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 29 Sep 2006 16:18:23 +0000 (09:18 -0700)
For len equal to 4, we never call sppp_lcp_conf_parse_options(),
therefore rmagic does not get initialized.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Paul Fulghum <paulkf@microgate.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/net/wan/syncppp.c

index d1173089f334a29d51f4375578bcd6bbca74493d..218f7b574ab3082012f2b4ec3a03262ffab98f9c 100644 (file)
@@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp *sp, struct sk_buff *skb)
        struct net_device *dev = sp->pp_if;
        int len = skb->len;
        u8 *p, opt[6];
-       u32 rmagic;
+       u32 rmagic = 0;
 
        if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
                if (sp->pp_flags & PP_DEBUG)