]> err.no Git - linux-2.6/commitdiff
[NET_SCHED]: sch_ingress: remove useless printk
authorPatrick McHardy <kaber@trash.net>
Mon, 21 Jan 2008 08:14:05 +0000 (00:14 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 23:08:22 +0000 (15:08 -0800)
The printk about ingress qdisc registration error can't be triggered
under normal circumstances. Since register_qdisc only fails for two
identical registrations, the only way to trigger it is by loading the
sch_ingress modules multiple times under different names, in which
case we already return -EEXIST to userspace.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Acked-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_ingress.c

index 4c7f7e7129184ea73e93d03def0a1acb11f1c490..72525710b66f49ea51a4c1b3cc682e65f338ce49 100644 (file)
@@ -221,14 +221,7 @@ static struct Qdisc_ops ingress_qdisc_ops __read_mostly = {
 
 static int __init ingress_module_init(void)
 {
-       int ret = 0;
-
-       if ((ret = register_qdisc(&ingress_qdisc_ops)) < 0) {
-               printk("Unable to register Ingress qdisc\n");
-               return ret;
-       }
-
-       return ret;
+       return register_qdisc(&ingress_qdisc_ops);
 }
 
 static void __exit ingress_module_exit(void)