]> err.no Git - linux-2.6/commitdiff
[TCP]: Fix unlikely usage in tcp_transmit_skb()
authorHua Zhong <hzhong@gmail.com>
Fri, 28 Apr 2006 22:26:50 +0000 (15:26 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Sun, 30 Apr 2006 01:33:19 +0000 (18:33 -0700)
The following unlikely should be replaced by likely because the
condition happens every time unless there is a hard error to transmit
a packet.

Signed-off-by: Hua Zhong <hzhong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_output.c

index a28ae593b97613d4d09a692e2363f24e2b59417b..743016baa04867473a022008367aa05a61bac284 100644 (file)
@@ -465,7 +465,7 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it,
        TCP_INC_STATS(TCP_MIB_OUTSEGS);
 
        err = icsk->icsk_af_ops->queue_xmit(skb, 0);
-       if (unlikely(err <= 0))
+       if (likely(err <= 0))
                return err;
 
        tcp_enter_cwr(sk);