]> err.no Git - linux-2.6/commitdiff
[SCSI] qla2xxx: Validate mid-layer 'underflow' during check-condition handling.
authorShyam Sundar <shyam.sundar@qlogic.com>
Thu, 19 Jul 2007 22:05:59 +0000 (15:05 -0700)
committerJames Bottomley <jejb@mulgrave.localdomain>
Fri, 20 Jul 2007 14:24:04 +0000 (09:24 -0500)
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/qla2xxx/qla_isr.c

index fa21cd86e9e250250cfb91d7a6cba22d907d55fe..4a50b931ca6f6c9220993ac3ba34a0eaee9ef128 100644 (file)
@@ -1062,6 +1062,25 @@ qla2x00_status_entry(scsi_qla_host_t *ha, void *pkt)
                            cp->device->id, cp->device->lun, cp,
                            cp->serial_number));
 
+                       /*
+                        * In case of a Underrun condition, set both the lscsi
+                        * status and the completion status to appropriate
+                        * values.
+                        */
+                       if (resid &&
+                           ((unsigned)(cp->request_bufflen - resid) <
+                            cp->underflow)) {
+                               DEBUG2(qla_printk(KERN_INFO, ha,
+                                   "scsi(%ld:%d:%d:%d): Mid-layer underflow "
+                                   "detected (%x of %x bytes)...returning "
+                                   "error status.\n", ha->host_no,
+                                   cp->device->channel, cp->device->id,
+                                   cp->device->lun, resid,
+                                   cp->request_bufflen));
+
+                               cp->result = DID_ERROR << 16 | lscsi_status;
+                       }
+
                        if (sense_len)
                                DEBUG5(qla2x00_dump_buffer(cp->sense_buffer,
                                    CMD_ACTUAL_SNSLEN(cp)));