]> err.no Git - linux-2.6/commitdiff
libata-pmp: 4726 hates SRST
authorTejun Heo <htejun@gmail.com>
Thu, 10 Jan 2008 04:38:46 +0000 (13:38 +0900)
committerJeff Garzik <jeff@garzik.org>
Thu, 10 Jan 2008 21:53:12 +0000 (16:53 -0500)
4726 hates SRST even on non-config ports.  Don't use it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-pmp.c

index c0c4dbcde091b5daf1805d2f4e180b0189e213b1..caef2bbd4a8a1525be252d6cfcf627901e52e261 100644 (file)
@@ -495,14 +495,12 @@ static void sata_pmp_quirks(struct ata_port *ap)
                        /* SError.N need a kick in the ass to get working */
                        link->flags |= ATA_LFLAG_HRST_TO_RESUME;
 
-                       /* class code report is unreliable */
-                       if (link->pmp < 5)
-                               link->flags |= ATA_LFLAG_ASSUME_ATA;
-
-                       /* The config device, which can be either at
-                        * port 0 or 5, locks up on SRST.
+                       /* Class code report is unreliable and SRST
+                        * times out under certain configurations.
+                        * Config device can be at port 0 or 5 and
+                        * locks up on SRST.
                         */
-                       if (link->pmp == 0 || link->pmp == 5)
+                       if (link->pmp <= 5)
                                link->flags |= ATA_LFLAG_NO_SRST |
                                               ATA_LFLAG_ASSUME_ATA;