]> err.no Git - linux-2.6/commitdiff
[SPARC64]: Fix off-by-1 error in TSB grow check.
authorDavid S. Miller <davem@sunset.davemloft.net>
Mon, 27 Mar 2006 09:07:55 +0000 (01:07 -0800)
committerDavid S. Miller <davem@sunset.davemloft.net>
Mon, 27 Mar 2006 09:07:55 +0000 (01:07 -0800)
The worst part about this bug is what it would cause
a hugepage TSB to be allocated for every address space
since "0 >= 0".

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc64/mm/fault.c

index d21ff3230c0227be384b83503e85f530a9b5fd22..0db2f7d9fab50ff57ff5d7125ed731afdbf5f445 100644 (file)
@@ -413,12 +413,12 @@ good_area:
 #ifdef CONFIG_HUGETLB_PAGE
        mm_rss -= (mm->context.huge_pte_count * (HPAGE_SIZE / PAGE_SIZE));
 #endif
-       if (unlikely(mm_rss >=
+       if (unlikely(mm_rss >
                     mm->context.tsb_block[MM_TSB_BASE].tsb_rss_limit))
                tsb_grow(mm, MM_TSB_BASE, mm_rss);
 #ifdef CONFIG_HUGETLB_PAGE
        mm_rss = mm->context.huge_pte_count;
-       if (unlikely(mm_rss >=
+       if (unlikely(mm_rss >
                     mm->context.tsb_block[MM_TSB_HUGE].tsb_rss_limit))
                tsb_grow(mm, MM_TSB_HUGE, mm_rss);
 #endif