]> err.no Git - linux-2.6/commitdiff
[AGPGART] Remove pointless assignment.
authorDave Jones <davej@redhat.com>
Sun, 28 Jan 2007 22:50:17 +0000 (17:50 -0500)
committerDave Jones <davej@redhat.com>
Sun, 28 Jan 2007 22:50:17 +0000 (17:50 -0500)
No point in clearing local pointers then returning.
Also fix up some CodingStyle nits.

Signed-off-by: Dave Jones <davej@redhat.com>
drivers/char/agp/ati-agp.c

index 0994d3534447cda78e6fd49c57fb39775da718fb..9987dc2e0c3f02474ba75994b9bc7d675e9904db 100644 (file)
@@ -124,18 +124,18 @@ static int ati_create_gatt_pages(int nr_tables)
        for (i = 0; i < nr_tables; i++) {
                entry = kzalloc(sizeof(struct ati_page_map), GFP_KERNEL);
                if (entry == NULL) {
-                       while (i>0) {
-                               kfree (tables[i-1]);
+                       while (i > 0) {
+                               kfree(tables[i-1]);
                                i--;
                        }
-                       kfree (tables);
-                       tables = NULL;
+                       kfree(tables);
                        retval = -ENOMEM;
                        break;
                }
                tables[i] = entry;
                retval = ati_create_page_map(entry);
-               if (retval != 0) break;
+               if (retval != 0)
+                       break;
        }
        ati_generic_private.num_tables = nr_tables;
        ati_generic_private.gatt_pages = tables;